Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Recent emojis not updated when adding via text #7998

Merged
merged 1 commit into from
Sep 4, 2017
Merged

[FIX] Recent emojis not updated when adding via text #7998

merged 1 commit into from
Sep 4, 2017

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Aug 31, 2017 •
edited
Loading

@RocketChat/core

  • Update the recent's list when adding via text Ex: :smile:
  • Show recent emojis first on emoji popup
  • Show emoji popup when type : directly, was expecting 2 chars to show it

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7998 August 31, 2017 13:12 Inactive
@rodrigok rodrigok requested a review from sampaiodiego August 31, 2017 13:14
@rodrigok rodrigok force-pushed the improvements/emoji-sort branch from ad3a89c to a8d5b80 Compare August 31, 2017 13:23
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-7998 August 31, 2017 13:23 Inactive
@rodrigok rodrigok added this to the 0.59.0-rc.4 milestone Aug 31, 2017
MartinSchoeler
MartinSchoeler requested changes Sep 1, 2017
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@rodrigok rodrigok force-pushed the improvements/emoji-sort branch from a8d5b80 to 5810ed3 Compare September 2, 2017 18:32
@rodrigok
Copy link
Member Author

rodrigok commented Sep 2, 2017

@MartinSchoeler Tests and review fixed

@rodrigok rodrigok merged commit e4709cc into develop Sep 4, 2017
@rodrigok rodrigok deleted the improvements/emoji-sort branch September 4, 2017 13:11
rodrigok added a commit that referenced this pull request Sep 5, 2017
@rodrigok
Merge pull request #7998 from RocketChat/improvements/emoji-sort
28cfdf5 
[FIX] Recent emojis not updated when adding via text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.59.0-rc.4
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigok @MartinSchoeler @engelgabriel