[FIX] Dynamic popover #8101
Merged
[FIX] Dynamic popover #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this space above the highlight desirable? looks the the search is broken again: the mobile paddings seems odd: |
|
Wrong status indicator alignment in Safari |
|
@sampaiodiego the space above the highlight was decided by @engelgabriel @rodrigok Fixed status indicator on Safari |
|
@karlprieb The animation on mobile is very slow.
|
|
@rodrigok fixed ;) |
rodrigok
approved these changes
Sep 13, 2017
rodrigok
added a commit
that referenced
this pull request
Sep 14, 2017
[FIX] Dynamic popover # Conflicts: # packages/rocketchat-ui-master/public/icons.svg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #8023
Create popovers dynamically.