Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Long room announcement cut off #8907

Merged
merged 7 commits into from
Dec 4, 2017
Merged

Conversation

karlprieb
Copy link
Contributor

@RocketChat/core

Closes #8888

image

@karlprieb karlprieb requested a review from ggazzo November 20, 2017 21:10
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8907 November 20, 2017 21:10 Inactive
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For long texts (not only a long word) the ellipsis still does not show and there is no hint/tooltip to see the whole announcement

image

@karlprieb
Copy link
Contributor Author

@sampaiodiego thanks for your review :) I fixed, take a look:

image

@soundstorm
Copy link
Contributor

But this won't work on mobile, right?
I don't know any mobile browser showing the title tag.

@karlprieb
Copy link
Contributor Author

@soundstorm No, do you have a suggestion on how this should work on mobile?
You can always open the Room Info tab to see the complete announcement :)

@soundstorm
Copy link
Contributor

@karlprieb could be an ontouch event with a popup, so title will show up on desktop and popup on mobile (and touch enabled desktops).

@rodrigok rodrigok added this to the 0.60.0 milestone Dec 4, 2017
@rodrigok
Copy link
Member

rodrigok commented Dec 4, 2017

@soundstorm Thanks by the suggestion, I'll merge this PR and we can improve it for mobile before the final release, is that ok @karlprieb ?

@rodrigok rodrigok changed the title [FIX] long announcement layout [FIX] Long room announcement cut off Dec 4, 2017
@rodrigok rodrigok merged commit 586b354 into develop Dec 4, 2017
@rodrigok rodrigok deleted the fix-long-announcement branch December 4, 2017 20:33
@karlprieb
Copy link
Contributor Author

Sure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Long room announcement cut off
6 participants