Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Change "Idle Time Limit" from milliseconds to seconds #9675

Closed
wants to merge 67 commits into from
Closed

[FIX] Change "Idle Time Limit" from milliseconds to seconds #9675

wants to merge 67 commits into from

Conversation

kaiiiiiiiii
Copy link
Contributor

@kaiiiiiiiii kaiiiiiiiii commented Feb 11, 2018

@RocketChat/core

Closes #9674

This PR changes the Idle Time Limit from milliseconds to seconds. Let me know if I missed something!

screen shot 2018-02-11 at 03 55 11

rodrigok and others added 30 commits December 27, 2017 22:59
[FIX] File access not working when passing credentials via querystring
…ation

[FIX] Remove sweetalert from livechat facebook integration page
[FIX] Restore translations from other languages
[FIX] Wrong position of notifications alert in accounts preference page
Fix: Change 'Wordpress' to 'WordPress
Fix: English language improvements
[FIX] LDAP/AD is not importing all users
[FIX] LDAP TLS not working in some cases
[FIX] Deleting message with store last message not removing
[FIX] Highlight setting not working correctly
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9675 February 16, 2018 10:21 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9675 February 16, 2018 12:13 Inactive
@kaiiiiiiiii
Copy link
Contributor Author

@geekgonecrazy Can you may take a look at my last commit and tell me if it's the right way to do a DB migration?

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9675 February 16, 2018 13:17 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9675 February 16, 2018 15:48 Inactive
@geekgonecrazy
Copy link
Contributor

I think everything looks right.

@sampaiodiego could you give a look and make sure looks good? I think you are more familiar with the idle code.

@geekgonecrazy geekgonecrazy added this to the 0.62.0 milestone Feb 17, 2018
@geekgonecrazy geekgonecrazy changed the title [FIX] Change "Idle Time Limit" from milliseconds to minutes [FIX] Change "Idle Time Limit" from milliseconds to seconds Feb 17, 2018
sampaiodiego and others added 4 commits February 20, 2018 10:13
…ion-without-register-form

[FIX] Livechat conversation not receiving messages when start without form
[FIX] Emoji rendering on last message
[FIX] Livechat issues on external queue and lead capture
@kaiiiiiiiii
Copy link
Contributor Author

kaiiiiiiiii commented Feb 20, 2018

@sampaiodiego Any chance to get this into the next release? Most of my users are really confused with the millisecond value.

@sampaiodiego
Copy link
Member

I'm sorry @kaiiiiiiiii we'll need to target version 0.63.0 since the feature set for 0.62.0 is already closed

@geekgonecrazy geekgonecrazy changed the base branch from master to develop February 20, 2018 19:42
@geekgonecrazy geekgonecrazy changed the base branch from develop to master February 20, 2018 19:42
@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Feb 20, 2018

@kaiiiiiiiii oooooh also just noticed your targeting master. Can you please switch to target develop?

We merge down to develop and then cut release off of develop.

On your fork you'll need to merge develop into master to get your master insync with our develop branch.

@kaiiiiiiiii
Copy link
Contributor Author

Closed in favor of #9824 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants