[FIX] Owner unable to delete channel or group from APIs #9729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0dzilla
changed the title
geekgonecrazy
changed the title
|
@geekgonecrazy please review. |
geekgonecrazy
previously approved these changes
Mar 30, 2018
|
@sampaiodiego this looks good to me. But any side effects you can think of? Looks pretty safe |
geekgonecrazy
changed the title
sampaiodiego
requested changes
Apr 2, 2018
There was a problem hiding this comment.
this changes are not applied on server updates. just fresh new installations will have the permission. we need a migration for this to be applied for server updates.
also, there is no UI for this new permissions, should we have them to be used by APIs and add an UI later?
c0dzilla
force-pushed
the
delete-permissions
branch
2 times, most recently
from
bcceb2a to
8b3faae
Compare
c0dzilla
force-pushed
the
delete-permissions
branch
from
8b3faae to
9936594
Compare
c0dzilla
force-pushed
the
delete-permissions
branch
from
9936594 to
a3618b4
Compare
|
@geekgonecrazy @sampaiodiego I've added the migration. |
|
Hope to find this changeset in a release soon (using RocketChat from a private Sandstorm installation here) |
sampaiodiego
changed the title
sampaiodiego
approved these changes
Apr 17, 2018
MarcosSpessatto
added a commit
that referenced
this pull request
Apr 19, 2018
…-api-chat-postmessage-validations * commit 'a9fb4da5c847a456990a5d60369f0f52ff4a8bd8': (137 commits) Remove "secret" from REST endpoint /settings.oauth response [FIX] Directory sort and column sizes were wrong (#10403) [FIX] Add oauth services missing fields, and indicate whether the oauth service is customized (#10299) Show error message when email verification fails (#10446) Correct the column positions in the directory search for users (#10454) Fixed custom fields misalignment in registration form (#10463) [FIX] Unique identifier file not really being unique (#10341) [OTHER] More Listeners for Apps & Utilize Promises inside Apps (#10335) [FIX] Empty panel after changing a user's username (#10404) [FIX] Russian translation of "False" (#10418) [FIX] Links being embedded inside of blockquotes (#10496) [FIX] The 'channel.messages' REST API Endpoint error (#10485) [OTHER] Develop sync (#10487) [FIX] Button on user info contextual bar scrolling with the content (#10358) [FIX] "Idle Time Limit" using milliseconds instead of seconds (#9824) [NEW] Body of the payload on an incoming webhook is included on the request object (#10259) [FIX] Missing i18n translation key for "Unread" (#10387) [FIX] Owner unable to delete channel or group from APIs (#9729) [NEW] REST endpoint to recover forgotten password (#10371) Add REST endpoint chat.reportMessage, to report a message (#10354) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #9704
Delete room privileges have been made default for owner.