Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web app manifest errors as reported by Chrome DevTools #9991

Merged

Conversation

justinribeiro
Copy link
Contributor

@RocketChat/core

Closes #9990

This pull request properly brings the web app manifest up-to-date to the current specification and resolves the incorrect start_url origin and the path to the broken images as seen in this screenshot.

This resolves the unwanted and incorrect behavior experienced in both Google Chrome and Mozilla Firefox for Android.

image

@ggazzo ggazzo added the ui/ux label Jul 5, 2018
@ggazzo ggazzo added this to the 0.67.0 milestone Jul 5, 2018
@ggazzo ggazzo merged commit f0f7ef2 into RocketChat:develop Jul 5, 2018
@theorenck theorenck modified the milestones: 0.67.0, 0.68.0 Jul 19, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Web App Manifest origin incorrect, icon images reference wrong path
3 participants