Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Tabs design update #427

Merged
merged 1 commit into from
Apr 15, 2021
Merged

fix: Tabs design update #427

merged 1 commit into from
Apr 15, 2021

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Apr 7, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Design:

image

Storybook

image

Issue(s)

Further comments

@dougfabris dougfabris requested a review from a team April 7, 2021 18:37
@ggazzo ggazzo changed the title improve: Tabs design update fix: Tabs design update Apr 15, 2021
@ggazzo ggazzo merged commit a34c7cd into develop Apr 15, 2021
@ggazzo ggazzo deleted the improve/tab-design branch April 15, 2021 18:18
gabriellsh added a commit that referenced this pull request Apr 26, 2021
@gabriellsh
Merge branch 'new/dropdown' of github.com:RocketChat/Rocket.Chat.Fuse…
385ea32 
…lage into new/dropdown

* 'new/dropdown' of github.com:RocketChat/Rocket.Chat.Fuselage:
  feat: @rocket.chat/string-helpers (#431)
  Fix develop (#432)
  fix: Hollow shapes for status (#430)
  fix: Modal close button size (#420)
  new: Add shredder icon for OTR messages (#423)
  fix: Change highlighted style (#422)
  fix: Tabs design update (#427)
  chore(build): Remove CircleCI configuration
  fix: Prefer null over undefined on BoxTransforms (#426)
  fix: Add more props to Throbber type definition (#429)
  fix: Remove reference to inexistent interface (#424)
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
📦 fuselage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougfabris @tassoevan @ggazzo