Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modal close button size #420

Merged
merged 2 commits into from
Apr 15, 2021
Merged

fix: Modal close button size #420

merged 2 commits into from
Apr 15, 2021

Conversation

tiagoevanp
Copy link
Contributor

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

image

Issue(s)

Further comments

@tiagoevanp tiagoevanp changed the title fix modal close size [FIX] Modal close button size Apr 2, 2021
@tiagoevanp tiagoevanp requested a review from a team April 2, 2021 23:23
@ggazzo ggazzo changed the title [FIX] Modal close button size fix: Modal close button size Apr 15, 2021
@ggazzo ggazzo merged commit 6279f69 into develop Apr 15, 2021
@ggazzo ggazzo deleted the fix/modal-close-button branch April 15, 2021 18:30
gabriellsh added a commit that referenced this pull request Apr 26, 2021
@gabriellsh
Merge branch 'new/dropdown' of github.com:RocketChat/Rocket.Chat.Fuse…
385ea32 
…lage into new/dropdown

* 'new/dropdown' of github.com:RocketChat/Rocket.Chat.Fuselage:
  feat: @rocket.chat/string-helpers (#431)
  Fix develop (#432)
  fix: Hollow shapes for status (#430)
  fix: Modal close button size (#420)
  new: Add shredder icon for OTR messages (#423)
  fix: Change highlighted style (#422)
  fix: Tabs design update (#427)
  chore(build): Remove CircleCI configuration
  fix: Prefer null over undefined on BoxTransforms (#426)
  fix: Add more props to Throbber type definition (#429)
  fix: Remove reference to inexistent interface (#424)
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagoevanp @ggazzo