feat: Position, Modal, Options components #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ggazzo
commented
Dec 23, 2019
•
ggazzo
commented
- Option list scrolling
- Simple positioning (top, bottom, right, left, center)
- open to the other side if there is no space
- recalc position on window scroll/resize
tassoevan
requested changes
Dec 24, 2019
Co-Authored-By: Tasso Evangelista <tasso.evangelista@rocket.chat>
…Fuselage into feature/position
ggazzo
force-pushed
the
feature/position
branch
from
b8cf595
to
ce2dbad
Compare
tassoevan
requested changes
Jan 2, 2020
Co-Authored-By: Tasso Evangelista <tasso.evangelista@rocket.chat>
ggazzo
changed the title
…Fuselage into feature/position
…into feature/position
ggazzo
force-pushed
the
feature/position
branch
from
19b5865
to
c873c1d
Compare
…Fuselage into feature/position
tassoevan
approved these changes
Jan 10, 2020
gabriellsh
added a commit
that referenced
this pull request
Jan 28, 2020
…into feat/tabs * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: fix plain text context (#132) feat: ui-kit initial value (#131) fix: ui-kit margins warnings and unique ids (#130) fix: Remove visibilty on transition (#129) fix: Modal's margins and AnimatedVisibility initial state (#128) fix: Modal background (#126) v0.2.0-alpha.19 fix: InputBox sizing (#124) fix: Position of inputs on selection buttons (#123) Create LICENSE (#122) feat: Position, Modal, Options components (#116)
gabriellsh
added a commit
that referenced
this pull request
Feb 4, 2020
…into feat/buttons * 'develop' of github.com:RocketChat/Rocket.Chat.Fuselage: v0.2.0-alpha.20 feat: UiKit error states (#133) chore: Development mode (#127) fix plain text context (#132) feat: ui-kit initial value (#131) fix: ui-kit margins warnings and unique ids (#130) fix: Remove visibilty on transition (#129) fix: Modal's margins and AnimatedVisibility initial state (#128) fix: Modal background (#126) v0.2.0-alpha.19 fix: InputBox sizing (#124) fix: Position of inputs on selection buttons (#123) Create LICENSE (#122) feat: Position, Modal, Options components (#116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.