Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing legacy icons #238

Merged
merged 4 commits into from
Jun 4, 2020
Merged

fix: Missing legacy icons #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e40fdc
Add missing menu icon alias
tassoevan Jun 4, 2020
dc76bf0
Recover menu icon alias
tassoevan Jun 4, 2020
e86bbcc
Declare icons as a fuselage peer dependency
tassoevan Jun 4, 2020
a60dee0
Recover user-rounded alias
tassoevan Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fuselage-ui-kit/src/Overflow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const Overflow = ({ context, options, parser, ...element }) => {
onKeyDown={handleKeyDown}
mod-loading={loading}
>
<Icon name='menu' size={20} />
<Icon name='kebab' size={20} />
</Button>
<PositionAnimated
width='auto'
Expand Down
Binary file modified packages/fuselage/.loki/reference/chrome_iphone7_Misc_Icon_Default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/fuselage/.loki/reference/chrome_iphone7_Misc_Menu_Default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/fuselage/.loki/reference/chrome_laptop_Misc_Icon_Default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/fuselage/.loki/reference/chrome_laptop_Misc_Menu_Default.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/fuselage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@
"update-storybook": "cross-env NODE_ENV=loki run-s build-storybook loki:update"
},
"peerDependencies": {
"@rocket.chat/fuselage-hooks": "^0.3.0",
"@rocket.chat/fuselage-hooks": "^0.9.0",
"@rocket.chat/icons": "^0.9.0",
"react": "^16.12.0",
"react-dom": "^16.12.0"
},
"dependencies": {
"@rocket.chat/css-in-js": "^0.9.0",
"@rocket.chat/fuselage-tokens": "^0.9.0",
"@rocket.chat/icons": "^0.9.0",
"invariant": "^2.2.4",
"react-keyed-flatten-children": "^1.2.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/fuselage/src/components/Menu/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const Menu = ({
onKeyDown={handleKeyDown}
{...props}
>
<Icon name='menu' size={20} />
<Icon name='kebab' size={20} />
</Button>
<PositionAnimated
width='auto'
Expand Down
1 change: 1 addition & 0 deletions packages/icons/src/aliases/menu.svg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../kebab.svg
1 change: 1 addition & 0 deletions packages/icons/src/aliases/user-rounded.svg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../avatar.svg