Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Modal Icon to Modal Component #410

Merged
merged 2 commits into from
Mar 22, 2021
Merged

feat: Add Modal Icon to Modal Component #410

merged 2 commits into from
Mar 22, 2021

Conversation

dougfabris
Copy link
Member

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Add a new Icon option on Modal as Modal.Icon

Issue(s)

Further comments

@dougfabris dougfabris requested a review from a team March 3, 2021 22:04
@dougfabris dougfabris changed the title improve: Add ModalIcon to Modal Component improve: Add Modal Icon to Modal Component Mar 3, 2021
@tassoevan tassoevan temporarily deployed to github-pages March 7, 2021 02:34 Inactive
@ggazzo ggazzo changed the title improve: Add Modal Icon to Modal Component feat: Add Modal Icon to Modal Component Mar 22, 2021
@ggazzo ggazzo merged commit c6a8b3e into develop Mar 22, 2021
@ggazzo ggazzo deleted the new/modal-icon branch March 22, 2021 20:20
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
📦 fuselage-hooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougfabris @ggazzo @tassoevan