Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @rocket.chat/message-parser #443

Merged
merged 67 commits into from
May 6, 2021
Merged

feat: @rocket.chat/message-parser #443

merged 67 commits into from
May 6, 2021

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 2, 2021

Supported markup

  • quotes
  • bold/italic/strike
  • ordered lists
  • unordered lists
  • task lists
  • phone numbers
  • phone numbers
  • mentions
  • emoji
  • colors
  • URI's
  • mentions users/channels

Observations and known issues

  • Nested lists
  • Url doesn't allow ( or )
  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@ggazzo ggazzo merged commit 4722cdf into develop May 6, 2021
@ggazzo ggazzo deleted the feat/message-parser branch May 6, 2021 18:10
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants