Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboarding-ui package #463

Merged
merged 7 commits into from
Jun 17, 2021
Merged

feat: onboarding-ui package #463

merged 7 commits into from
Jun 17, 2021

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Jun 1, 2021 •
edited
Loading

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@tassoevan tassoevan requested a review from a team June 4, 2021 22:31
@tassoevan tassoevan added the 📦 onboarding-ui @rocket.chat/onboarding-ui label Jun 4, 2021
@tassoevan tassoevan marked this pull request as ready for review June 4, 2021 22:32
@tassoevan tassoevan requested review from dougfabris and gabriellsh and removed request for a team June 4, 2021 23:19
@tassoevan tassoevan requested review from a team and removed request for dougfabris and gabriellsh June 17, 2021 13:24
@ggazzo ggazzo merged commit ea0a6c2 into develop Jun 17, 2021
@ggazzo ggazzo deleted the feat/onboarding-ui-package branch June 17, 2021 13:31
gabriellsh added a commit that referenced this pull request Jun 23, 2021
@gabriellsh
Merge branch 'new/image-manipulation' of github.com:RocketChat/Rocket…
9daed46 
….Chat.Fuselage into new/image-manipulation

* 'new/image-manipulation' of github.com:RocketChat/Rocket.Chat.Fuselage:
  Update tsconfig.json
  chore: Update icon building readme (#472)
  fix: Menu component and options.label prop type (#476)
  fix: endReached prop in _Options of PaginatedSelectFiltered Component (#475)
  fix: Export MultiSelect component in .d.ts file (#473)
  feat(ui-kit): Attachment Surface (#474)
  fix(fuselage): Fuselage production build (#477)
  feat: onboarding-ui package (#463)
  fix(eslint): Add missing ESLint rule for TypeScript (#470)
  fix(string-helpers):  typesVersions (#469)
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
📦 onboarding-ui @rocket.chat/onboarding-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo