-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] MediumMultilineInput
and LargeMultilineInput
Elements
#766
base: main
Are you sure you want to change the base?
Conversation
@MartinSchoeler @ggazzo can you guys please take a look at this PR and suggest any changes |
@dougfabris @tassoevan Can you guys please take a look and suggest any changes ? |
cf7ada3
to
801d4cc
Compare
@gabriellsh @yash-rajpal Can you please take a look and guide me with this PR. Feel free to message me over Rocket.Chat Open Server samad.khan whenever you find time :) |
801d4cc
to
b42b4f2
Compare
b42b4f2
to
78afec0
Compare
multilineLarge?: boolean; | ||
multilineMedium?: boolean; | ||
multilineSmall?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this some part of other protocol? if there is no standard or compatibility I would stay with something like
multilineSize: 'large' | 'medium' | 'small'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggazzo Thanks a lot for the review ! Yes, seems like a better option to have it that way. We can stick tomultilineSize: 'large' | 'medium' | 'small'
. I will make the required changes.
78afec0
to
674e67d
Compare
@ggazzo I have updated the parameters for |
@ggazzo can you please take a look at this again ? I have made changes according to review comments. |
a1c5724
to
fe695b1
Compare
77be55a
to
a97c7f0
Compare
feat: New
MediumMultilineInput
andLargeMultilineInput
ElementsWhy Do We need this ?
Larger Multiline Input Elements will open new possibilities for Rocket.Chat App Developers.
Larger input components can be used in future apps which include a Code Editing App where the developers pair program inside Rocket.Chat.
Or a Journal App/Notes App where journal Entries or more extensive notes can be made in RC
Or a Future GitLab integrations where a code Review and Edit feature will be desirable.
Larger can even be used in the main chat input component to edit and send a larger message to the Rocket.Chat channel, which may not be possible with the current input component.
Our use case and motivation to add this component to fuselage was to enable users display and merge PRs right from RocketChat channels through the GitHub App. This will be an exclusive feature which is not available in any
GitHub x Messaging
app intigration.We currently use the
SectionBlock
as theInputBlock
is too small, but theSectionBlock
looses the indentation.2022-07-15.20-13-48.mp4
A Larger Input component can help us take fix this as it preserves indentation. This would improve community collaboration over Rocket.Chat and push
Messaging x Developer Collaboration
to the limitsThe Same component can also be extended to add new Issues to GitHub or A Rocket.Chat app which parses and display markdown. The possibilities can be endless.
Updating the Multi-Line InputBlock #744
Proposed changes (including videos or screenshots)
Added New
MediumMultilineInput
andLargeMultilineInput
elements to fuselage-ui-kit.Added the new elements to the storybook.
Input With Medium Multiline Plane Text Input
2022-07-11.05-33-07.mp4
2022-07-11.05-33-33.mp4
Input With Large Multiline Plane Text Input
2022-07-11.05-34-02.mp4
2022-07-11.05-34-29.mp4
Issue(s)
closes #765