Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #3

Merged
merged 3 commits into from
Jul 11, 2020
Merged

Updates #3

merged 3 commits into from
Jul 11, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll added the 🚀 feature This adds some form of new functionality label Jul 11, 2020
@github-actions github-actions bot added this to the v0.1.0 milestone Jul 11, 2020
@david-driscoll david-driscoll added the :shipit: merge Shipit! label Jul 11, 2020
@codecov
Copy link

codecov bot commented Jul 11, 2020

Codecov Report

Merging #3 into master will decrease coverage by 0.34%.
The diff coverage is 38.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
- Coverage   64.79%   64.45%   -0.35%     
==========================================
  Files         137      138       +1     
  Lines        2369     2391      +22     
  Branches      203      205       +2     
==========================================
+ Hits         1535     1541       +6     
- Misses        834      850      +16     
Impacted Files Coverage Δ
src/AspNetCore/Validation/ValidatorInterceptor.cs 0.00% <ø> (ø)
src/Extensions/FluentValidationExtensions.cs 25.00% <0.00%> (ø)
src/Testing/FakeClockConvention.cs 57.14% <0.00%> (-42.86%) ⬇️
src/Extensions/Conventions/NodaTimeConvention.cs 12.50% <12.50%> (ø)
...ensions/Validation/PolymorphicPropertyValidator.cs 15.00% <33.33%> (ø)
...Validation/AspNetCoreFluentValidationExtensions.cs 89.74% <60.00%> (+0.13%) ⬆️
src/AspNetCore/Conventions/AspNetCoreConvention.cs 93.10% <100.00%> (+1.10%) ⬆️
...ful/Composition/RestfulApiActionModelConvention.cs 92.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87edd01...6772235. Read the comment docs.

@david-driscoll david-driscoll merged commit bf1a15d into master Jul 11, 2020
@mergify mergify bot removed the :shipit: merge Shipit! label Jul 11, 2020
@mergify mergify bot deleted the updates branch July 11, 2020 04:29
@github-actions github-actions bot modified the milestones: v0.1.0, v0.1.1 Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feature This adds some form of new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant