Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a different way to work with msbuild... we'll see! #1312

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll enabled auto-merge (squash) September 5, 2024 01:04
@github-actions github-actions bot added this to the v2.8.0 milestone Sep 5, 2024
@david-driscoll david-driscoll merged commit 843fbf8 into master Sep 5, 2024
8 checks passed
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 9.24855% with 157 lines in your changes missing coverage. Please review.

Project coverage is 8.07%. Comparing base (9fe9f7e) to head (b5fd163).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Nuke/ProjectModel/MsbProject.cs 5.71% 66 Missing ⚠️
src/Nuke/ProjectModel/NukeSolutionExtensions.cs 17.64% 56 Missing ⚠️
src/Nuke/ProjectModel/MsbSolution.cs 0.00% 9 Missing ⚠️
src/Nuke/ProjectModel/MsbProperty.cs 0.00% 8 Missing ⚠️
src/Nuke/IHavePublicApis.cs 0.00% 7 Missing ⚠️
src/Nuke/ICanPrettier.cs 0.00% 3 Missing ⚠️
src/Nuke/ProjectModel/MsbPackageReference.cs 0.00% 3 Missing ⚠️
src/Nuke/SolutionExtensions.cs 0.00% 3 Missing ⚠️
src/Nuke/MsBuild/ICanTestWithXUnit.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1312      +/-   ##
=========================================
+ Coverage    7.94%   8.07%   +0.12%     
=========================================
  Files         154     153       -1     
  Lines        4230    4162      -68     
  Branches      325     318       -7     
=========================================
  Hits          336     336              
+ Misses       3894    3826      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Sep 5, 2024
@github-actions github-actions bot modified the milestones: v2.8.0, v2.8.1 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants