Add option for overriding MBC type #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rodrigodd
force-pushed
the
override-mbc
branch
from
7514d3c to
668478b
Compare
Will now deduce the size of the rom and ram if they are invalid, and ignore things like the header checksum. In does cases `Cartridge::new` will return a `Err((erro, Some(cartridge)))`. The ui frontned is just printing the error message and using the cartridge, but ideally it would prompt the user for confirmation.
You can know pass, for example, `--mbc='MBC1,0x8000,0x2000'` to the cli to override the mbc type, rom size and ram size.
Rodrigodd
force-pushed
the
override-mbc
branch
from
668478b to
5bda6a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can know pass, for example,
--mbc='MBC1,0x8000,0x2000'to the cli to override the mbc type, rom size and ram size.Fix #12.