Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arkanoid show score, lives. Fix NULL pointer dereference #188

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

DevMilanIan
Copy link

What's new

  • Display dots representing 3 lives on the left, score on the right. Also fixed timer not being freed and mutex deletion, however this somehow has made the game 'remember' your lives and score after exit, but not any brick/level progress. This could lead to issues but none that I have found yet. Tried a few things and had no luck, not too experienced here so any tips in the comments would be great.

Verification

  • Going to the current Arkanoid game, playing until at least one brick is hit, then closing the game will lead to a NULL pointer dereference upon reopen or after a short while. Now it will 'remember' your lives and score, show them, and hopefully not crash you later.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@RogueMaster RogueMaster merged commit 8a7fa18 into RogueMaster:unleashed Aug 6, 2022
@UberGuidoZ
Copy link

Thanks, @DevMilanIan! If you're able to PR this over to Unleashed as well, it will get built into the base of RogueMaster and benefit even more people. =)

Though I'm sure Unleashed could just grab it, they prefer the authors to do it. Otherwise, I'd be happy to do it too, but this is yours and you should be attached to it! Appreciate it.

https://github.com/Eng1n33r/flipperzero-firmware

RogueMaster pushed a commit that referenced this pull request Oct 31, 2023
RogueMaster pushed a commit that referenced this pull request Oct 31, 2023
RogueMaster pushed a commit that referenced this pull request Dec 2, 2023
2dd92db add lib back
a0ff0ba remove submodule
952c674 sync license of totp plugin
4d791b7 update totp
dcc5d48 update totp and include cli plugins
574c3ac upd totp ver
12ace98 update totp
293b36d update totp
58440b2 update totp
020928c move base pack here
REVERT: b082440 Dropped OFW-catalog specific stuff. Changed license to GPLv3 (#208)
REVERT: d5b30ab Updated descriptions
REVERT: 87cb8b2 Updated version
REVERT: 69659e8 Implemented #205 (#206)
REVERT: 54fe1db Implemented #203 (#204)
REVERT: e8c5187 Updated changelog for OFW catalog
REVERT: 005df8c Updated version
REVERT: 726d1a5 Disable Crypto v1 by default
REVERT: 172f292 Implemented #200 (#201)
REVERT: 6513672 Implemented #198 (#199)
REVERT: b106c91 Updated version
REVERT: ebc6eab Update DESCRIPTION.md
REVERT: cd20802 Update CHANGELOG.md
REVERT: dca6043 Small fix
REVERT: 88a9666 Updated version
REVERT: 62cff06 Implemented #195 (#196)
REVERT: 3d1c00e Updated version
REVERT: 4f6d25c clang format
REVERT: 0d9c3b2 Implemented #193
REVERT: 07752e5 Updated version
REVERT: 8f86849 Fixed #190 (#191)
REVERT: 9c6c257 Updated version
REVERT: cd5cd64 Implemented #188 (#189)
REVERT: 2593677 Updated changelog for OFW catalog
REVERT: f9834a0 Updated version
REVERT: 68646aa Revert "Updated version"
REVERT: 77cc775 Updated version
REVERT: 57fdb34 Revert "Updated version"
REVERT: 22c6ff2 Updated version
REVERT: 86a90ab Implemented #185 (#187)
REVERT: afe7e56 Refactoring (#184)
REVERT: 446e0a1 Refactoring (#183)
REVERT: 1b3e5d8 Fixed #178 (#182)
REVERT: a9de233 Update CHANGELOG.md
REVERT: af5b9f2 Implemented #177 (#179)
REVERT: 658125b Ghi 171 (#176)
REVERT: bc5daa2 Implemented #171 (#175)
REVERT: 0604b90 FIxed #172 (#174)
REVERT: 19fbbe0 Fixed #169 (#170)
REVERT: 3790f18 Implemented #167 (#168)
REVERT: 2a6a725 Corrected stuff for OFW catalog
REVERT: e134591 Update CHANGELOG.md
REVERT: 1b4673e Closing #165 (#166)
REVERT: 6315ccc Code cleanup
REVERT: 0a424a5 CLang format
REVERT: bf3952d Code cleanup
REVERT: 749fbf4 Got rid of useless things I found
REVERT: d0cb734 CLang format
REVERT: 0ee50f3 Updated changelog
REVERT: 4c3d75d Closing #162 and prepared for OFW catalog (#163)
REVERT: 654d929 Returning back original category
REVERT: c0efd36 Fixed file name naming
REVERT: 7054937 clangformat
REVERT: ab7bbb9 Few tweaks for OFW catalog (#161)
REVERT: 5627bc9 * Fix for #158
REVERT: 44a0949 Refactoring 6 6 (#157)
REVERT: a89d15e Fixed #155 (#156)
REVERT: 9713ccb Fix for #153 (#154)
REVERT: 123f421 * Updated firmware references (#151)
REVERT: d13bcd7 Closing #148 (#150)
REVERT: bc1eab7 Improved token input automation code to get rid of caps lock key usage (#147)
REVERT: 1020c3c Refactoring (#144)
REVERT: 4d3e208 Added banner image for FlipC webpage
REVERT: d8bf9c5 Moved FlipC screenshots (#143)
REVERT: c11a722 Refactoring & bugfixes (#142)
REVERT: 3458f0a Implemented #137 (#141)
REVERT: 168c6e9 Implemented #138 (#139)
REVERT: 9df6fc5 * Added `--clean` flag to custom FBT tool (#133)
REVERT: 7b34241 Refactoring (#130)
REVERT: 0a9cc9e Fix BT adv name length on Xtreme firmware (#126)
REVERT: a8ea396 Closing #123 (#124)
REVERT: 5aff2f0 Refactoring. Dropping useless methods #120 (#121)
REVERT: b4e434b * Firmware submodules updated (#119)
REVERT: cb111a6 Fixed #116 (#117)
REVERT: 6ca8a70 Added Steam algo (#115)
REVERT: 2d52c78 Xtreme firmware build (#114)
REVERT: 16ba603 Implemented #106 (#107)
REVERT: 2901da8 Implemented #103 (#105)
REVERT: 5b6aedb Implemented #102 (#104)
REVERT: fd60525 Implemented #95 (#97)
REVERT: 03a7f93 Implemented BadBT automation (#91)
REVERT: 97c6116 Updated firmware references (#88)
REVERT: 44df62c * Updated firmware submodules (#76) (#78)
REVERT: ebb0a3a * Updated firmware submodules (#72) (#73)
REVERT: f7e7550 Affecting dolphin level at start (#71)
REVERT: 141f424 Cosmetic fixes
REVERT: 41c23ba Implementation of #65 (#66)
REVERT: cd7c9c7 Initial changes on #58 (#59)
REVERT: 2a69aa2 Fix for #53 (#54)
REVERT: ba15840 Fix for #51 (#52)
REVERT: b718e64 Implemented #49 (#50)
REVERT: 7bb00ea Use dedicated config directory instead of app folder (#48)
REVERT: 805adfe Implemented #36 (#38)
REVERT: fbb9d22 Clang format ran (#35)
REVERT: fea22d7 Implemented PIN changing via CLI (#32)
REVERT: 018aa7e Implemented #30 (#31)
REVERT: ee4252c Implemented #26 (#27)
REVERT: 9dcb6cb Fixed #24 (#25)
REVERT: 766a3d6 Implemented "type code in badusb mode"
REVERT: 3a111ef Clang format ran
REVERT: 44879ec Refactoring (#22)
REVERT: bd0e3c9 Reduced code size to avoid weird issue with COMPACT=1 DEBUG=0 build (#19)
REVERT: a11332c PVS-Studio pipeline (#18)
REVERT: e8bcd90 Refactoring (#17)
REVERT: 70f84f0 Still fixing SONAR issues (#15)
REVERT: 57d83e7 Fixed SONAR issues (#14)
REVERT: a5fcc23 Fixing SONAR issues (#13)
REVERT: 8d7167c Ran clang format
REVERT: 8083b9e CLI help text refactoring to better match http://docopt.org/ standard
REVERT: 1a51c11 Clang format ran
REVERT: 3a08fee Few more refactoring
REVERT: a8f2ca0 Improved authentication handling in CLI
REVERT: 4c5533f * Refactoring
REVERT: bc9836e * Updated firmware submodules
REVERT: 75b3849 A better fix for #8
REVERT: 2674ab5 Fixed issue #6
REVERT: a55ac88 Refactoring.
REVERT: 526213c Clang format ran
REVERT: 0483d8f * Fixed "Add new token" scene.
REVERT: 9c1d1b9 * Made PIN optional (#4)
REVERT: 5ea454e Added timezone configuration UI
REVERT: c0a9aa7 Updated format specifier where were wrong
REVERT: 5f8e55e Well... CLI was nice idea, but I can't make it work. Maybe next time
REVERT: 99e8ceb * Updated to FuriString
REVERT: e85da67 Initial commit. Moved all the code and setup flipper firmware as submodule

git-subtree-dir: totp
git-subtree-split: 2dd92db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants