Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipper Name Changer - Initial Upload #259

Merged
merged 2 commits into from
Aug 21, 2022

Conversation

ESurge
Copy link

@ESurge ESurge commented Aug 21, 2022

What's new

Flipper Name Changer

Initial Upload

  • Didn't upload modified meta/applications.fam. Use APPS_NameChanger
  • Still causes HardFaults sometimes
  • Creates and uses name.txt file located in /ext/dolphin/ folder (Uses special format)
  • Runs a function at system start to check name file and apply custom name if file exists.
    -- If file doesn't exist, file is created with current name (default or CUSTOM_FLIPPER_NAME)
  • Requires the uploaded/modified furi_hal_version files
  • Modified furi_hal_version will keep CUSTOM_FLIPPER_NAME modification, but NameChanger will overwrite local name if name.txt exists at startup (minus Bluetooth name)

Verification

Method 1

  • Run NameChanger app and change name.
  • Name will save to file, and apply to device immediately (minus Bluetooth name)

Additional Checks 1

  • If no name.txt file exists, NameChanger will use default device name or hardcoded CUSTOM_FLIPPER_NAME
  • name.txt will be created and saved with the name

Additional Checks 2

  • If name.txt file exists, NameChanger will update device name to use the name in the file

Additional Checks 3

  • Modifying name.txt file and restarting the device will update the name.

Note: No character protection in place currently.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

ESurge added 2 commits August 21, 2022 05:04
- Didn't upload modified meta/applications.fam. Use `APPS_NameChanger`
- Still causes HardFaults sometimes
- Creates and uses name.txt file located in /ext/dolphin/ folder (Uses special format)
- Runs a function at system start to check name file and apply custom name if file exists.
-- If file doesn't exist, file is created with current name (default or custom_flipper_name)
- Requires the uploaded/modified furi_hal_version files
- Modified furi_hal_version will keep CUSTOM_FLIPPER_NAME modification, but will overwrite local name changes on boot (minus Bluetooth name)
@RogueMaster RogueMaster merged commit 0837cc7 into RogueMaster:unleashed Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants