Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restored Infrared and RFID CLI #405

Merged
merged 6 commits into from
Nov 4, 2022
Merged

Restored Infrared and RFID CLI #405

merged 6 commits into from
Nov 4, 2022

Conversation

ESurge
Copy link

@ESurge ESurge commented Nov 4, 2022

What's new

  • Since the move to FAP for Infrared and RFID, CLI was missing - This restores that functionality

Verification

  • Get into CLI
  • Run the Infrared/RFID commands
  • Ensure the commands are working properly

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@ESurge ESurge requested a review from RogueMaster as a code owner November 4, 2022 21:30
@ESurge
Copy link
Author

ESurge commented Nov 4, 2022

Don't merge yet - this breaks IR FAP

@RogueMaster RogueMaster added bug Something isn't working enhancement New feature or request labels Nov 4, 2022
@RogueMaster RogueMaster marked this pull request as draft November 4, 2022 21:47
@ESurge ESurge marked this pull request as ready for review November 4, 2022 22:25
@RogueMaster RogueMaster merged commit 53d5177 into RogueMaster:420 Nov 4, 2022
@RogueMaster RogueMaster mentioned this pull request Nov 30, 2022
Closed
RogueMaster pushed a commit that referenced this pull request Apr 2, 2023
@xMasterX
Merge pull request #405 from gid9798/custom-buttons
6b7b95e 
Unification of custom buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogueMaster RogueMaster Awaiting requested review from RogueMaster RogueMaster is a code owner

Assignees

@ESurge ESurge

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ESurge @RogueMaster