Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameChanger Update #488

Merged
merged 1 commit into from
Jan 6, 2023
Merged

NameChanger Update #488

merged 1 commit into from
Jan 6, 2023

Conversation

ESurge
Copy link

@ESurge ESurge commented Jan 6, 2023

What's new

  • Fixed crash on main NameChanger app
  • Fixed rare boot loop crash with NameChangerSRV when flashing firmware
  • Cleaned up code on NameChanger in general to be less complicated

Verification

  • NameChanger app should function without issue now
  • NameChangerSRV should update device name without issue now
  • Both NameChanger app and SRV should read/write name.txt file properly

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@ESurge
Fixed crash with NameChanger app
b3ccfb5 
Fixed boot loop crash with NameChangerSRV

Cleaned up code on NameChanger in general to be less complicated
@RogueMaster RogueMaster merged commit 51de982 into RogueMaster:420 Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogueMaster RogueMaster Awaiting requested review from RogueMaster RogueMaster is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ESurge @RogueMaster