Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlist two APIs as requested by author #1155

Closed
wants to merge 1 commit into from

Conversation

Anduh
Copy link
Contributor

@Anduh Anduh commented Dec 21, 2020

Unlist two APIs, as requested in Issue #950.

There was an attempt to do this with PR #1106, but as described in issue #1136, adding "hidden" to an API in approved.yaml doesn't work like it does in the character sheet repo, so the only way to unlist APIs is to remove their entry from the file altogether.

@Solarswordsman
Copy link
Member

This may cause unintended side effects for games that might have these old scripts in them.

We'll review possible effects and have a resolution soon, likely similar to the hidden feature of character sheets.

@Anduh
Copy link
Contributor Author

Anduh commented Dec 22, 2020

We'll review possible effects and have a resolution soon, likely similar to the hidden feature of character sheets.

That would be great change to the APIs. There are a number of APIs that seems to be listed under more than one category by appearing twice in the approved.yaml, and looking more into how that work would make it possible to categorize APIs under multiple categories if more fitting that way.

It could also be a good idea to introduce/create new API categories, as both "System Toolbox" and "Utility" are fairly large and non-descriptive.

  • D&D 5E for all D&D 5E-specific APIs, as there are plenty of them.
  • Libraries for all APIs that are only meant as support for APIs and not used directly by users. Moving all those APIs from "Utitlity" to this category and have the "Libraries" listed at the bottom of the dropdown out of convenience.

@Anduh
Copy link
Contributor Author

Anduh commented Dec 27, 2020

A workaround would be to list all API intended to be discontinued under a "xDiscontinued" category that would move those API to the bottom of the list, placing the category last.

@Anduh Anduh closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants