[HeroSystem6eHeroic_HDImporter] Updates to support newest sheet. Code simplification. Bug fixes. #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update the HERO Designer importer for HeroSystem6eHeroic. It adds support for the new features on the sheet and simplifies older repetitive code where possible.
A summary of changes to the each of the files in the submission:
HeroSystem6eHeroic_HDImporter.js (Version 2.0):
Updated martial maneuvers to allow for 10 maneuver slots with 10 additional to text.
Updated to import 20 direct powers directly and 10 additional to text.
Updated support for 10 perks and talents and 10 additional to text.
Updated support for 10 complications and 10 additional to text.
More robust parsing of description text for purging double quotes.
More robust error checking for imported data.
Added function to make an armor entry (#4) for resistant protection powers.
Imports all HD description text fields.
Added import of height and Weight.
Added everyman skills.
Enhancement powers apply characteristic mods where appropriate.
Recognizes talents purchased as powers.
Better interpretation of variable power pool control/pool costs.
Added Untiring (zero END for STR) option check.
Added check for armor X END/Turn if entered in notes.
Backwards compatibility/notification for the older version export format (HeroSystem6eHeroic.hde 1.0).
Simplification of repetitive code (~60% reduction overall).
Bug Fixes:
Fixed missing comma typo in Equipment10 of HDE.
Fixed verbose import reporting inaccuracies.
HeroSystem6eHeroic.hde (Version 2.0):
Updated HDE file export format version to 2.0 to increase number of powers, complications, and descriptions.
Added equipment notes.
Minor bug fixes.
Updated README.MD.
Updated json.