Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sheet - Deathmatch Island #12212

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

timdenee
Copy link
Contributor

@timdenee timdenee commented Oct 3, 2023

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: Deathmatch Island

  • The publisher of this game is: Evil Hat Productions

  • The name of this game system/family is: Paragon

  • I have followed the Character Sheets Standards when building this sheet.

  • This sheet has been made on behalf of, or by, the game's publisher.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@BronsonHall
Copy link
Contributor

Hey @timdenee
One small note - your translations file needs to be named translation.json, rather than deathmatch_island.json in order for the translations service to apply changes.

@timdenee
Copy link
Contributor Author

timdenee commented Oct 5, 2023

@BronsonHall Ah yes, cheers - fixed now!

@NorWhal
Copy link
Contributor

NorWhal commented Oct 9, 2023

Hi @timdenee, sorry to raise a second blocker for you, but the entire translations folder needs to be removed. I can see you're just initializing the files for crowdin, but we have an automated handler for new sheets that does what you've done once they've been added, and the presence of these files will cause a series of merge conflicts.

This is why our Sheet Standards does not allow editing the two-letter translations files: all of that should be handled through Crowdin

@timdenee
Copy link
Contributor Author

timdenee commented Oct 9, 2023

@NorWhal Thanks Nora - that's been removed now!

@NorWhal NorWhal merged commit c11c40b into Roll20:master Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants