Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everyday Heroes 1.6: Fix DC roll error #12227

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

Kurohyou
Copy link
Contributor

@Kurohyou Kurohyou commented Oct 12, 2023

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • This sheet has been made on behalf of, or by, the game's publisher.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Bug Fixes

  • Fixes an issue with how DCs were calculated when making rolls so that they no longer display as a concatenation of 8 and the attribute modifier

@Kurohyou Kurohyou requested a review from a team as a code owner October 12, 2023 18:56
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@BronsonHall BronsonHall merged commit 008c887 into Roll20:master Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants