Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star Wars Revised RPG: New Feature #13337

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

WilliamBarkerCoC
Copy link
Contributor

Added skill point tabulation base on rankings

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

The main request, by "The Nameless", was to tabulate skill points used via rankings in order to compare total skill points with skill points used.
The sheet has been updated:

  • allow a granularity of 0.5 points and issues warning ('invalid value' - on hover) when negative values input for ranks
  • made changes to repeating sections ‘checkbox’ to cause a re-tabulation
  • re-coded how categories (regular, dark force, light force, profession, craft, knowledge & entertain) retotaling cause a recalculation of used point total
  • replaced defunct URL for logo with a user supplied black and white JediVsSith image

In accordance with what I have read, I will be updating the code (bug fix?) later to reflect the new URL for the logo, assuming this update is approved, and the image find a home on the Roll20 GitHub.

Tested under:
Chrome: Version 128.0.6613.113
Firefox: Version 130.0

Added skill point tabulation base on rankings
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@NorWhal NorWhal merged commit 5982c99 into Roll20:master Sep 24, 2024
1 check passed
@WilliamBarkerCoC WilliamBarkerCoC deleted the SWRRPG.wb branch October 4, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants