GH-438 Bukkit OfflinePlayer argument #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I improved
LiteBukkitFactory
by addingbuild(Plugin)
method,Plugin
bind and exposingPlugin->fallbackPrefix
algorithm to public.I added a very useful
OfflinePlayer
argument resolver. This time, a made it more smart that it's previous generations: now it checks and warns if called synchronously, as I noticed a lot of problems when using that in sync - this could not occur at testing time but sometimes just freezes the server in production, so we should prevent that softly.Also, now it collects as many nicknames as possible by caching player names, so suggestions should be much more useful than just
Server#getOnlinePlayers
.Feel free to edit / request changes, as my style might be different from yours.
Also, I would be happy if you would make a release after merging that, so we can start using it. Thank you!