Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-438 Bukkit OfflinePlayer argument #438

Merged

Conversation

BlackBaroness
Copy link
Contributor

Hi!

I improved LiteBukkitFactory by adding build(Plugin) method, Plugin bind and exposing Plugin->fallbackPrefix algorithm to public.

I added a very useful OfflinePlayer argument resolver. This time, a made it more smart that it's previous generations: now it checks and warns if called synchronously, as I noticed a lot of problems when using that in sync - this could not occur at testing time but sometimes just freezes the server in production, so we should prevent that softly.

Also, now it collects as many nicknames as possible by caching player names, so suggestions should be much more useful than just Server#getOnlinePlayers.

Feel free to edit / request changes, as my style might be different from yours.

Also, I would be happy if you would make a release after merging that, so we can start using it. Thank you!

@Rollczi
Copy link
Owner

Rollczi commented Oct 1, 2024

Hi!

Thanks for the improvements! I will introduce a small adjustment and release it in version 3.6.1.

@Rollczi Rollczi changed the title Bukkit OfflinePlayer argument GH-438 Bukkit OfflinePlayer argument Oct 1, 2024
@Rollczi Rollczi merged commit 1c7f418 into Rollczi:master Oct 1, 2024
5 checks passed
@BlackBaroness BlackBaroness deleted the feature/bukkit/offline-player-argument branch October 1, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants