Ron azar Resources and Services #22

RonAzar · 2024-09-16T06:21:14Z

No description provided.

…t of owner

…d include the table name

…nted by enum) and return their name, dateOfArrival and company Id

…nd return their name, employee Id and company Id. +The unit-tests doesn't work yet

it should be on company_id and employee_id

…nted by enum) and return their name, dateOfArrival and company Id

…nd return their name, employee Id and company Id. +The unit-tests doesn't work yet

…JOOQ-Omer # Conflicts: # src/main/kotlin/com/hibob/academy/dao/OwnerDao.kt # src/main/kotlin/com/hibob/academy/dao/PetDao.kt # src/test/kotlin/com/hibob/academy/dao/OwnerDaoTest.kt # src/test/kotlin/com/hibob/academy/dao/PetDaoTest.kt

src/main/kotlin/com/hibob/academy/resource/OwnerResource.kt

src/main/kotlin/com/hibob/academy/resource/PetsResource.kt

src/main/kotlin/com/hibob/academy/service/OwnerService.kt

src/main/kotlin/com/hibob/academy/service/PetService.kt

…is redundant. Why 2 twice companyId in path?

200 response is enough, You can return here Unit.

RonAzar added 30 commits September 8, 2024 15:05

Not Finshed yet

a34c508

Class Exercise-SQL

23f3ba6

May's Review-the name of the file should be the date it was created

6224b5a

May's Review-index should include the table name

5ab3350

May's Review-where id=2

abe6e4d

May's Review- DEFAULT date value

51edf29

May's Review- rename to id, the owner part is redundant in the contex…

c18f7f4

…t of owner

May's Review- should be not null

e7a5289

May's Review- employee_id is string in bob also should be not null

ad5e85d

May's Review- should be one index on both columns, and the name shoul…

934fdc7

…d include the table name

May's Review- Thank's for the review!

da4fb7d

May's Review- Adding test migration

ea4d4ec

Not finshed yet

f3be6db

Create a function that retrieve all the pets by a given type (represe…

128a9ac

…nted by enum) and return their name, dateOfArrival and company Id

Create a function that retrieve all the owners from the owner table a…

20c9ff5

…nd return their name, employee Id and company Id. +The unit-tests doesn't work yet

May review- should be bigint in hibob

b0b9a68

May review- There is no point in putting an index on a primary key

788ccee

it should be on company_id and employee_id

May review- maybe this file is causing you problems you can remove it

6a6ff04

Complete

031a669

unique index

28c5b5a

Not finshed yet

48a1047

Create a function that retrieve all the pets by a given type (represe…

4d0de72

…nted by enum) and return their name, dateOfArrival and company Id

Create a function that retrieve all the owners from the owner table a…

f22849c

…nd return their name, employee Id and company Id. +The unit-tests doesn't work yet

Complete class exercise

f12c49c

Complete class exercise

ada0129

Complete class exercise

ac1d80c

Remove unique index from Pets

e22c14e

change unique index to index

398c88d

Change my enum class TYPE name to a more unique and representing name

e7b747a

RonAzar commented Sep 17, 2024

View reviewed changes

src/main/kotlin/com/hibob/academy/resource/OwnerResource.kt Outdated Show resolved Hide resolved

RonAzar changed the base branch from RonAzar/JOOQ-Omer to master September 17, 2024 07:46

RonAzar added 8 commits September 17, 2024 11:44

Merge branch 'master' into RonAzar/Resource-And-Service-Omer

85975e0

fixed test in github

88a0f29

Fixed Pet resource and service

6d9e3cb

Fixed Owner & Pet resource and service

dc19be2

Fixed Owner & Pet resource and service

4014908

Merge branch 'master' into RonAzar/Resource-And-Service-Omer

b29382d

Change data classes to reasonable names

83c8009

Update package path

f32692a