Refactored permission validation in RolePermissionValidator #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t less dependent on specific API endpoints. Moved role and permission checks closer to where they are used in resource classes, enhancing maintainability and adhering to clean code principles. recognize abortWith doesn't work properly
vasofi
approved these changes
Sep 26, 2024
RonAzar
added a commit
that referenced
this pull request
Sep 26, 2024
* Phase 2 - Step 4: Implement HR Response API
•Added FeedbackResponseResource.kt to handle feedback response submissions.
•Integrated role and permission checks to ensure authorized access for response submission.
* Phase 2 - Step 4: Implement HR Response API
•Added FeedbackResponseResource.kt to handle feedback response submissions.
•Integrated role and permission checks to ensure authorized access for response submission.
* fix to--> it's cleaner if you do:
if (no permission) return
* Refactored permission validation in RolePermissionValidator to make it less dependent on specific API endpoints. Moved role and permission checks closer to where they are used in resource classes, enhancing maintainability and adhering to clean code principles. (#51)
recognize abortWith doesn't work properly
RonAzar
added a commit
that referenced
this pull request
Sep 26, 2024
* Phase 2 - Step 4.2: complete FeedbackResource
•Implemented API endpoints for get Status, update Status, get Filtered Feedbacks
* fix to--> it's cleaner if you do:
if (no permission) return
* Response resource (#49)
* Phase 2 - Step 4: Implement HR Response API
•Added FeedbackResponseResource.kt to handle feedback response submissions.
•Integrated role and permission checks to ensure authorized access for response submission.
* Phase 2 - Step 4: Implement HR Response API
•Added FeedbackResponseResource.kt to handle feedback response submissions.
•Integrated role and permission checks to ensure authorized access for response submission.
* fix to--> it's cleaner if you do:
if (no permission) return
* Refactored permission validation in RolePermissionValidator to make it less dependent on specific API endpoints. Moved role and permission checks closer to where they are used in resource classes, enhancing maintainability and adhering to clean code principles. (#51)
recognize abortWith doesn't work properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored permission validation in RolePermissionValidator to make it less dependent on specific API endpoints. Moved role and permission checks closer to where they are used in resource classes, enhancing maintainability and adhering to clean code principles.
recognize abortWith doesn't work properly