- Add carn run init command #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This command uses techpowerup api for getting results
- It also generates a default config
- Added test for regex parsing of CPU name
- Fix docker.rs nano_id image name generation
- Previously sometimes nano generated a name with _ or -
this leads to docker failing to create a container and
intermittend failing of tests
- Fix libs.rs unix test, match statement didn't consider name
Closed
- Removed tar, bytes & uuid
Added docker example to default config
Closed
- Added function for getting the cpu name from sysinfo. - Added function for getting avg_power for cpu from Boavizta. - Added CLI 'wizard' to create a new config. - Cleaned template for example configs.
ohuu
force-pushed
the
58-add-cardamon-init-command
branch
from
626dfd6
to
73b6bab
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ohuu
I have added the init command, I have opted to not use the string comparison algorithm, and opted for regex, let me know if this is acceptable.
Primarily because if the user forgets to add "K,U,..." to their CPU ( e.g. 'i7-13700k/u/...' or 'Ryzen 7 5700/X/X3D) it will prompt them for a manual choice
Lib.rs and docker stuff can be removed and put into another branch / commit if needed ( They're v small changes )