Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evidence View - sort by pvalue #310

Closed
AjitPS opened this issue Feb 15, 2019 · 2 comments
Closed

Evidence View - sort by pvalue #310

AjitPS opened this issue Feb 15, 2019 · 2 comments
Assignees
@AjitPS
Labels
enhancement Use this for a change about existing functionality, use 'new feature' for new functionality.

Comments

@AjitPS
Copy link
Collaborator

AjitPS commented Feb 15, 2019

Suggestion: Sort Evidence View by p-value column when exists, instead of just by score.

Recent bug as we no longer have separate with and without keyword searchModes. Fix: code check for p-values and if found >0, use that column to sort in utils.js/tablesorter
@AjitPS AjitPS added the enhancement Use this for a change about existing functionality, use 'new feature' for new functionality. label Feb 15, 2019
@AjitPS AjitPS self-assigned this Feb 15, 2019
@KeywanHP KeywanHP changed the title EvidenceView - sorter Evidence View - sort by pvalue Jul 8, 2019
@AjitPS
Copy link
Collaborator Author

AjitPS commented Jul 10, 2019

@dicknetherlands fyi, for a keyword search without a gene list, p-value remains 0.00000 and we use the knet_score to sort evidence view results while for non-keyword searc or keyword+gene list search, p-value is calculated per evidence term but the evidence view table still gets sorted just by score and not p-value (as it should be).

AjitPS pushed a commit that referenced this issue Jul 31, 2019
issue #310 fixed evidenceView tablesorter
dfa2e5f
AjitPS added a commit that referenced this issue Jul 31, 2019
@AjitPS
Merge pull request #392 from AjitPS/master
11f8be2 
 issue #310 fixed
@AjitPS
Copy link
Collaborator Author

AjitPS commented Jul 31, 2019

fixed in 11f8be2

@AjitPS AjitPS closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AjitPS AjitPS

Labels
enhancement Use this for a change about existing functionality, use 'new feature' for new functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AjitPS