Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting keywords in Network fails when multiple keywords found side-by-side #311

Closed
AjitPS opened this issue Feb 15, 2019 · 3 comments
Assignees
Labels
bug enhancement Use this for a change about existing functionality, use 'new feature' for new functionality.

Comments

@AjitPS
Copy link
Collaborator

AjitPS commented Feb 15, 2019

Search: dormancy OR anthocyanin highlights these 2 terms differently in various network nodes, which works well.

However, search: stripe rust fails as some matches (for wheat stripe rust disease) have all the search keywords next to each other in the node attributes and that breaks the highlighter code server-side (that replaces keywords with ____keywords____ and then replaces ____ with color-coded html <span>

Status: To be fixed in future release.

@AjitPS AjitPS added bug enhancement Use this for a change about existing functionality, use 'new feature' for new functionality. labels Feb 15, 2019
AjitPS added a commit that referenced this issue Jun 17, 2019
@KeywanHP KeywanHP assigned mdonepudi and dicknetherlands and unassigned AjitPS and KeywanHP Jul 9, 2019
@KeywanHP
Copy link
Member

Issue might be here:

private boolean highlight(ONDEXConcept concept, Map<String, String> keywordColourMap) {

@AjitPS
Copy link
Collaborator Author

AjitPS commented Sep 11, 2019

Highlighting works now, but fails when using wildcards in search.

e.g., in HumanDisease KnetMiner https://knetminer.rothamsted.ac.uk/HumanDisease/ (using latest release_3.1 code) search for alzheimer and visualizing network of 1st gene in GeneView highlights labels correctly in KnetMaps; but fails when searching for alzhei*. @mdonepudi @KeywanHP

@AjitPS AjitPS reopened this Sep 11, 2019
@KeywanHP
Copy link
Member

The original issue has been fixed. New ticket needed for the new wildcard issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement Use this for a change about existing functionality, use 'new feature' for new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants