Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for full or partial concept accessions is not working, eg TO:0000286 #345

Closed
KeywanHP opened this issue Mar 11, 2019 · 5 comments
Assignees
Labels

Comments

@KeywanHP
Copy link
Member

The example below should only show paths between gene:TraesCS2B02G184100 and TO:0020057
http://knetminer.rothamsted.ac.uk/wheatknet/genepage?keyword=0020057&list=TraesCS2B02G184100

But it shows many other paths...

It works fine if instead of the the TO accession, the TO name is used:
http://knetminer.rothamsted.ac.uk/wheatknet/genepage?keyword=leaf%20AND%20rust%20AND%20response&list=TraesCS2B02G184100

@KeywanHP
Copy link
Member Author

KeywanHP commented Aug 6, 2019

I just checked that TO is included in the list of Accession Data Sources to be searched, and yes it is there:

String[] datasources = {"PFAM", "IPRO", "UNIPROTKB", "EMBL", "KEGG", "EC", "GO", "TO", "NLM", "TAIR",

So maybe the Lucene search is doing something funny with digits:

@KeywanHP KeywanHP assigned mdonepudi and dicknetherlands and unassigned AjitPS and KeywanHP Aug 6, 2019
@KeywanHP KeywanHP assigned AjitPS and KeywanHP and unassigned mdonepudi and dicknetherlands Aug 28, 2019
@AjitPS AjitPS removed their assignment Aug 28, 2019
@AjitPS
Copy link
Collaborator

AjitPS commented Aug 28, 2019

We have internally deployed KnetMiner:master (2 weeks ago) for testing Arabidopsis on http://babvs72.rothamsted.ac.uk:8091/client/

Querying with a gene and TO term: http://babvs72.rothamsted.ac.uk:8091/ws/araknet/genepage?keyword=0002616&list=AT2G25930 shows gene plus 235 other (visible) concepts out of total: 419; with various Phenotype & 7 visible Trait nodes (1 of which is TO:0002616)

KeywanHP added a commit that referenced this issue Aug 29, 2019
The Lucene field is called ConceptAccession_DSID
@KeywanHP
Copy link
Member Author

Checked the Lucene index with Luke and spotted a tiny typo which meant the KnetMiner search was not considering concept accessions.

@KeywanHP KeywanHP reopened this Aug 29, 2019
@AjitPS
Copy link
Collaborator

AjitPS commented Aug 29, 2019

Still does not highlight TO term when, e.g., TO:0002616 or 0002616, used in keyword.

also, http://localhost:9090/ws/aratiny/genepage?keyword=%22plant%20height%22&list= throws this new error:
[qtp293108580-22] ERROR rres.knetminer.datasource.ondexlocal.OndexServiceProvider - Lucene search failed
java.lang.IllegalStateException: field "ConceptAccession_IPRO" was indexed without position data; cannot run PhraseQuery (phrase=ConceptAccession_IPRO:"plant height")
at org.apache.lucene.search.PhraseQuery$PhraseWeight.scorer(PhraseQuery.java:411) ~[lucene-core-6.6.0.jar:6.6.0 5c7a7b65d2aa7ce5ec96458315c661a18b320241

@KeywanHP
Copy link
Member Author

KeywanHP commented Aug 30, 2019

The fix had unlocked another issue with the way concept accessions were indexed in Lucene. It has now been resolved in Ondex LuceneEnv. Following queries are now working as expected:

ws/aratiny/genepage?keyword="TO:0000286"&list=AT1G13180
ws/aratiny/genepage?keyword=0000286&list=AT1G13180

@KeywanHP KeywanHP changed the title Paths highlighting is not correct when keyword is a TO id Searching for full or partial concept accessions is not working, eg TO:0000286 Aug 30, 2019
AjitPS added a commit that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants