-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Javascript 3rd-party dependencies from the Knetminer codebase #366
Comments
for both Genomaps/ and KnetMaps/ in |
After some investigation, this should be a reasonable plan. Javascript refactoringWork on the original Javascript repositories, KnetMaps and GenoMaps. For each of them:
KnetMiner refactorisationOnce the Js repo is re-arranged and can publish distro files, Go to KnetMiner and make client-base dependant on the distro only. At the moment this module has duplicates of both repositories and rebuilds everything (with bower, NPM, etc) during the Maven build. Clearly, this is redundant and needs to be factories. So,
|
I've checked out the work done so far for knemap.js. Sounds good, I'm leaving just a few notes, in case it's useful to keep track of them:
|
@manlikleo please close if completed. |
This is practically completed, except for a few minor details:
|
@marco-brandizi @lawal-olaotan please close if done |
I've just copied my local clone of the Knetminer codebase and I realised there are directories with huge size, which seem to contain 3rd-party Javascript dependencies, eg, node_modules. This slows down operations like copies and Docker builds.
We should improve this and put those files out of our code base. One way to do it might be to see if there are already published Maven modules that could be linked from our POMs. Or, if no such thing exists, we could create separated Maven modules and link them.
The text was updated successfully, but these errors were encountered: