Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeneMap assets and GitHub #448

Closed
marco-brandizi opened this issue Oct 15, 2019 · 4 comments
Closed

GeneMap assets and GitHub #448

marco-brandizi opened this issue Oct 15, 2019 · 4 comments
Assignees

Comments

@marco-brandizi
Copy link
Member

marco-brandizi commented Oct 15, 2019

Files in GeneMap keep being changed by Maven builds, yet they are managed by git/github and this isn't good.

Are those files auto-generated? Then, they shouldn't be versioned, nor downloaded from github, they should generated when needed. Actually, they shouldn't be in that location either, for the convention is to have Maven-generated files in target/ (ref).

If they are expected to be generated manually, from time to time, this isn't what's happening and hence changes to POM(s) are required.

@marco-brandizi
Copy link
Member Author

marco-brandizi commented Oct 15, 2019

It seems to depend on .gitattributes, setting all files to LF newline style is too much and causes all those fake differences. See here for details.

@AjitPS, @josephhearnshaw, @KeywanHP, @ssamberkar if you don't have problems with the new version of this file, I can close this issue.

@AjitPS
Copy link
Collaborator

AjitPS commented Oct 15, 2019

everything in genemap/dist/ is built by npm/gulp (like KnetMaps/dist/) but the dist/ contents and dependencies like genemap/.node_modules, etc. are all already in their own .npmignore (https://github.com/Rothamsted/knetminer/blob/master/common/client-base/src/main/webapp/html/GeneMap/.npmignore), and should be in root knetminer .gitignore too (and I think they are)

@AjitPS
Copy link
Collaborator

AjitPS commented Oct 15, 2019

if .gitattributes fixes it, then happy to have it, as long as we retain everything apart from that (i.e., what's needed by npm/gulp to build/optimize/minify genemap/ and knetmaps/) in .gitignore and .npmignore

@marco-brandizi
Copy link
Member Author

OK, I'll align the two ignore files.

AjitPS referenced this issue in AjitPS/KnetMiner Oct 16, 2019
AjitPS added a commit that referenced this issue Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants