#352 made variables (scoredCandidates and mapGene2Concepts) threadsafe #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mdonepudi , what's the reason for the new Map |
|
We could have removed genes and refactored to use geneMap instead, for presentation sake, but we prioritised fixing the code. Given that you intend to retire this class, going into too much effort to make it perfect seems redundant.
…Sent from my iPhone
On 31 Jul 2019, at 14:02, Ajit Singh ***@***.***> wrote:
Thanks @mdonepudi , what's the reason for the new Map geneMap being used?? while still having the genes arraylist?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.