Fixed issue #401 #412
Merged
Fixed issue #401 #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorts correctly & enables genes without evidence to show
Noted that network legend doesn't update with menu option; fixed this.
|
thoughts on this @mdonepudi , we can pull this to close issue #401 if it doesn't conflict at your end.. would be good to update dockerhub too with this and |
KeywanHP
requested review from
marco-brandizi
and removed request for
mdonepudi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorts correctly & enables genes without evidence to show.
Works correctly, apologies for reformatting causing the large diff. Changes in OndexServiceProvider is in line 705, method
getScoredGenesMap- seePublic Map<ONDEXConcept, Double> getScoredGenesMap(Map<ONDEXConcept, Float> hit2score)Altered use of ValueComparator and TreeMap to simply sorting via map stream - see below:
sortedCandidates = scoredCandidates .entrySet() .stream() .sorted(Collections.reverseOrder(Map.Entry.comparingByValue())) .collect( toMap(Map.Entry::getKey, Map.Entry::getValue, (e1, e2) -> e2, LinkedHashMap::new)); // Sort the candidate valuesAlso ensured that the user genes are added back to the geneMap