Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for update in base images #3448

Open
bschmalhofer opened this issue Jun 6, 2024 · 14 comments
Open

Check for update in base images #3448

bschmalhofer opened this issue Jun 6, 2024 · 14 comments
Assignees
Labels
docker Docker related issues enhancement New feature or request
Milestone

Comments

@bschmalhofer
Copy link
Contributor

In Docker Hub there are usually no automatic rebuilds of Images when a base images changes. But base images might change because there are security fixes. So it is interesting to be at least notified when a base image is updated.

There a several ways how to approach this. Let's try first https://github.com/marketplace/actions/docker-image-update-checker .

@bschmalhofer bschmalhofer added enhancement New feature or request docker Docker related issues labels Jun 6, 2024
@bschmalhofer bschmalhofer added this to the Wishlist milestone Jun 6, 2024
@bschmalhofer bschmalhofer self-assigned this Jun 6, 2024
bschmalhofer added a commit that referenced this issue Jun 6, 2024
as the command contains double quotes
bschmalhofer added a commit that referenced this issue Jun 6, 2024
as the command contains a colon
bschmalhofer added a commit that referenced this issue Jun 6, 2024
because it didn't run at 11:20
bschmalhofer added a commit that referenced this issue Jun 14, 2024
that is '08' instead of '8'
bschmalhofer added a commit that referenced this issue Jun 14, 2024
note that scheduled workflows only run on the default branch
@bschmalhofer
Copy link
Contributor Author

Still trying to get to a working schedule workflow. The action DockerImageUpdateChecker seems to be active, but there are no runs yet.

@bschmalhofer bschmalhofer modified the milestones: Wishlist, OTOBO 10.0 Jun 23, 2024
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jun 24, 2024

Fiddled with .github/workflows/docker_image_update_checker.yml so that it can be started manually. An error message should be written when the base image was updated. Let's wait until such an update occured and see how the output looks like.
The last push of the Perl images were 9 days ago, so it looks like upgrades are not really frequent.

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jun 30, 2024

Also, when rebuilding an image, then dockerfile.snapshot should be used for installing the Perl modules from CPAN.

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jul 4, 2024

The Perl Image was update and the check indicated this:

grafik

TODO:

  • Indicate that the base image was updated also in the list of recent actions

@bschmalhofer
Copy link
Contributor Author

When the check for changes in the base images is implemented then there will be fairly frequent rebuilds of Docker images. These rebuilds include the installation of CPAN distributions into the Docker image. Currently most of the CPAN dependencies are installed with their most current versions on CPAN. This is fine for infrequent builds as there the builds are tested before they are tagged and built automatically on Docker Hub. For rebuilding already released versions we want a more stable setup. Specifically we want that the same versions of CPAN distrubutions are installed into the rebuilt image. This can be achieved with cpanfile.snapshot support in Carton.

See also #210.

bschmalhofer added a commit that referenced this issue Jul 18, 2024
we want to build with otobo.web.dockerfile instead of Dockerfile
bschmalhofer added a commit that referenced this issue Jul 18, 2024
just because the default value is documented as {context}/Dockerfile
bschmalhofer added a commit that referenced this issue Jul 18, 2024
bschmalhofer added a commit that referenced this issue Jul 18, 2024
This allows to print more info
bschmalhofer added a commit that referenced this issue Jul 24, 2024
we want to build with otobo.web.dockerfile instead of Dockerfile
bschmalhofer added a commit that referenced this issue Jul 24, 2024
just because the default value is documented as {context}/Dockerfile
bschmalhofer added a commit that referenced this issue Jul 24, 2024
bschmalhofer added a commit that referenced this issue Jul 24, 2024
This allows to print more info
bschmalhofer added a commit that referenced this issue Jul 24, 2024
no need to build the kerberos-web image
bschmalhofer added a commit that referenced this issue Jul 24, 2024
in this case the tag is devel-11_1_test
bschmalhofer added a commit that referenced this issue Jul 24, 2024
Specifically image.source and image.version
bschmalhofer added a commit that referenced this issue Jul 25, 2024
@bschmalhofer
Copy link
Contributor Author

TODO:

  • expand the matrix to also cover 10_0 and 10_1, including special case for 10_0 that has no target

@bschmalhofer
Copy link
Contributor Author

This needs to be tested again, especially as there were some changes done for #3673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant