Prepare package for public consumption and contributions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotu
requested changes
Jul 3, 2019
- Get linter tests passing - Remove development crumbs from package.xml and CMakeLists.txt
This test will only work on UNIX-based systems.
rotu
reviewed
Jul 10, 2019
rotu
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the most part, these changes are superficial and linter-related.
The most notable exception is that I corrected the namespace delimiter in the parameters from a
/to a., which will need a corresponding update in the OpenRover config files.Once the
serialpackage is available in ROS 2, we can think about submitting this as a standard ROS 2 package, at which point we can leverage the ROS 2 buildfarm for CI and PR builds of this repository.These updates make the package buildable on OSX and Windows as well, though the end-to-end smoke test only runs on UNIX-based systems, so it is excluded from Windows testing.
After this is merged, I'd like to tag the first release of the package.