Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): Fix label in ie 11 #1654

Merged
merged 1 commit into from
Nov 12, 2020
Merged

fix(Dropdown): Fix label in ie 11 #1654

merged 1 commit into from
Nov 12, 2020

Conversation

thyhjwb6
Copy link
Collaborator

@thyhjwb6 thyhjwb6 commented Nov 9, 2020

Related issue

Fixes #1580

Overview

Fixes the Dropdown label positioning in IE 11.

Reason

This is because of an issue with align-items: center and min-height: x in IE 11 which can be worked around by adding a pseudo element.

Work carried out

  • Fix ie 11 issue

Screenshot

Look at the Chromatic differences.

Developer notes

The proposed workaround was taken from a Github comment.

@thyhjwb6 thyhjwb6 self-assigned this Nov 9, 2020
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #1654 (341a456) into master (6faa5f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1654   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files         188      188           
  Lines        2218     2218           
  Branches      566      566           
=======================================
  Hits         2168     2168           
  Misses         50       50           
Impacted Files Coverage Δ
...onent-library/src/components/Dropdown/Dropdown.tsx 100.00% <ø> (ø)

@thyhjwb6 thyhjwb6 changed the title [WIP] fix(Dropdown): Fix label in ie 11 fix(Dropdown): Fix label in ie 11 Nov 10, 2020
@thyhjwb6 thyhjwb6 added Package: react-component-library Package/code type Type: Bug Inconsistencies or issues which have caused a problem for users or implementors labels Nov 10, 2020
@thyhjwb6 thyhjwb6 marked this pull request as ready for review November 10, 2020 09:20
Copy link
Member

@m7kvqbe1 m7kvqbe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented Nov 12, 2020

Code Climate has analyzed commit 341a456 and detected 0 issues on this pull request.

View more on Code Climate.

@thyhjwb6 thyhjwb6 merged commit 4a91022 into master Nov 12, 2020
@thyhjwb6 thyhjwb6 deleted the fix/dropdown-ie11 branch November 12, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-component-library Package/code type Type: Bug Inconsistencies or issues which have caused a problem for users or implementors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown padding/spacing in IE 11
2 participants