Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi bytes characters in some regex of RegexFilter #306

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix multi bytes characters in some regex of RegexFilter #306

merged 1 commit into from
Sep 20, 2023

Conversation

ElGigi
Copy link
Contributor

@ElGigi ElGigi commented Sep 11, 2023

Problem: the replacement of multi bytes characters, without an ascii match, leads to a NULL

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ElGigi
Copy link
Contributor Author

ElGigi commented Sep 11, 2023

I have read the CLA Document and I hereby sign the CLA

@andrewdalpino
Copy link
Member

Awesome, thank you @ElGigi!

@andrewdalpino andrewdalpino merged commit 8792955 into RubixML:master Sep 20, 2023
1 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
@ElGigi ElGigi deleted the fix-regex-filter branch January 16, 2024 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewdalpino andrewdalpino andrewdalpino approved these changes

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElGigi @andrewdalpino @Jeckerson