Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(currency): Albanian Lek subunit should be 1 #1092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

allencch
Copy link

When using JavaScript Intl.NumberFormat, it shows different subunit for Albanian Lek currency. For example,

let numFormat = new Intl.NumberFormat('en-US', { style: 'currency', currency: 'ALL' });
let { minimumFractionDigits } = numFormat.resolvedOptions();
console.log(minimumFractionDigits);
// Result shows 0 instead of 2

Hence, I think it is necessary to change the Albanian Lek subunits to 1.
I believe this will be a breaking change as well.

@semmons99
Copy link
Member

can you find a web reference (wikipedia, ministry of finance, etc) that confirms this is true and include in changelog please.

@allencch
Copy link
Author

The currency in Albania is the Lek. The smallest unit is 1 Lek and there are no cents.

link

This is so far the most direct reference I can find.

I can't find any related change log or ICU source code on how the minimumFractionDigits is configured.

@semmons99
Copy link
Member

semmons99 commented Apr 15, 2024 via email

@tagliala
Copy link
Contributor

tagliala commented Jun 4, 2024

Hi, there is an opposite request at #1098. The request here is to "remove subunits to match the fact that subunits are no longer produced", there is to "reintroduce subunits to match ISO 4217"

In the example file linked there, https://www.six-group.com/dam/download/financial-information/data-center/iso-currrency/lists/list-one.xml, still has 2 decimals for ALL

@matid
Copy link

matid commented Jul 3, 2024

Maintainers should make a decision if the gem is meant to follow conventions/common use or ISO standards and be clear what is being returned.

If there's interest in doing both, methods should be clearly labeled to indicate if iso values or common values are returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants