Make some fields on objects/map objects immutable #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise LOVE will die when the error gets concatted later.
LÖVE doesn't like absolute paths, but we don't emulate this behavior headlessly, so it was missed.
This is somewhat more complicated than the rest, so I'm expecting regressions. location gets stored on the metatable. Now that the metatable is keeping individual state per object, it no longer makes sense to share them between cloned objects, so a bit of code was added to MapObject.clone() to account for that.
Ruin0x11
added
enhancement
Ruin0x11
force-pushed
the
feature/change-object-prototype
branch
from
d821958
to
37d9948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Related issues
#135.
Description
Makes a bunch of fields that shouldn't be modifiable on objects/map objects immutable by hiding them in the metatable.
This changes a bit in how serialization works, so I expect some amount of regressions, but there are a lot of tests to match.