Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.2.1 #52

Merged
merged 10 commits into from
Oct 23, 2023
Merged

v1.2.1 #52

merged 10 commits into from
Oct 23, 2023

Conversation

alihm
Copy link
Member

@alihm alihm commented Oct 23, 2023

  • Fixes mysql-dump crash issue
  • Other fixes and improvements
  • Extra snapshot before executing the backup

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 23, 2023
View reviewed changes
ui/index.html
$('#modal-spinner').show();
window.execute_spinner.classList.remove('d-none');
window.import_in_progress = true;
const result = await axios.post(`${window.apiURL}/executebackup`, { filename }, { timeout: 200000 });

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused variable result.
ui/index.html
Comment on lines +567 to +568
$('#confirm-modal .modal-body').html(`<span><i class="fas fa-exclamation-triangle text-danger"></i> This action is irreversible, Are you sure to execute this file?<br><b>${filename}.sql</b></span></br>
<div class="spinner-border" id="modal-spinner" style="width: 1rem; height: 1rem; border: 0.2em solid #000; border-right-color: transparent;" role="status">`);

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
ClusterOperator/server.js
log.info(`${filesImported.length} SQL file(s) imported.`);
res.send('OK');
}).catch((err) => {
res.status(500).send(JSON.stringify(err));

Check warning

Code scanning / CodeQL

Information exposure through a stack trace

This information exposed to the user depends on [stack trace information](1). This information exposed to the user depends on [stack trace information](2).
@alihm alihm merged commit 354496d into master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alihm