Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Interval to the PI Review Page to Wait for Question Data #583

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ibrahimmoazzam
Copy link
Contributor

This PR contains some changes related to adding an interval to the PI Review Page since some instructors have said they can't view any data (e.g., the correct answer, feedback, voting results) for certain questions. As I can't replicate the problem due to the Review Page functioning perfectly on my local system, I might have to add more changes to fix the problem.

@ibrahimmoazzam ibrahimmoazzam changed the title Add: Interval to the PI Review Page Add: Interval to the PI Review Page to Wait for Question Data Nov 21, 2024
@bnmnetp
Copy link
Member

bnmnetp commented Nov 22, 2024

If the data is not in #questions-data when the page is loaded, its not going to appear later. Maybe you want to change to get the data you need using an API, that way you could call the API after a small delay, or call it again if you don't get the data the first time.

I think this would also be more in line with future directions if we should convert all of the peer instruction interfaces to use React.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants