Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #121 - 지도 영역 가이드 추가 #122

Merged
merged 10 commits into from
Apr 1, 2023
Merged

[Feat] #121 - 지도 영역 가이드 추가 #122

merged 10 commits into from
Apr 1, 2023

Conversation

lsj8706
Copy link
Collaborator

@lsj8706 lsj8706 commented Mar 27, 2023 •
edited
Loading

🌱 작업한 내용

  • 지도 캡처 로직 개선
  • 지도 영역에 필요한 가이드 추가
  • 로그인 로직 수정

🌱 PR Point

  • GuideView 를 Component로 만들었습니다.

📸 스크린샷

구현 내용 스크린샷
가이드뷰 Simulator Screen Recording - iPhone 13 - 2023-03-27 at 22 53 49

📮 관련 이슈

@lsj8706 lsj8706 added Feat 새로운 기능 구현 세진☃️ labels Mar 27, 2023
@lsj8706 lsj8706 self-assigned this Mar 27, 2023
dlwogus0128
dlwogus0128 reviewed Apr 1, 2023
View reviewed changes
Copy link
Contributor

@dlwogus0128 dlwogus0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와...

@dlwogus0128 dlwogus0128 self-requested a review April 1, 2023 01:50
@dlwogus0128
Copy link
Contributor

너무 멋져요..

dlwogus0128
dlwogus0128 approved these changes Apr 1, 2023
View reviewed changes
Copy link
Contributor

@dlwogus0128 dlwogus0128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋져요!!!!!!!!!

@lsj8706 lsj8706 merged commit 674ac7e into Runnect:develop Apr 1, 2023
@lsj8706 lsj8706 deleted the feat/#121-지도영역-가이드 branch April 1, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwogus0128 dlwogus0128 dlwogus0128 approved these changes

@lee-yeonwoo lee-yeonwoo Awaiting requested review from lee-yeonwoo

Assignees

@lsj8706 lsj8706

Labels
Feat 새로운 기능 구현 세진☃️
Projects
Runnect-iOS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 지도 영역 가이드 추가
2 participants
@lsj8706 @dlwogus0128