Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlwogus0128
added
Chore
lsj8706
approved these changes
May 16, 2023
| } else { | ||
| // 수정이 된 상태라면 팝업을 띄워주기 | ||
| self.navibar.resetLeftButtonAction({ [weak self] in | ||
| self?.navibar.leftButton.addTarget(self, action: #selector(self?.presentToQuitEditAlertVC), for: .touchUpInside) |
There was a problem hiding this comment.
resetLeftButtonAction을 사용하는 방식으로 수정하셨군요!
혹시 여기서 157줄에서 addTarget을 하지 않고 바로
presentToQuitEditAlertVC()로 적으면 원하는대로 동작을 안 할까요?
There was a problem hiding this comment.
오!! 돼요! 근데 왜 addTarget을 하지 않아도 동작을 하는지 궁금합니다...!
There was a problem hiding this comment.
resetLeftButtonAction 함수 내부를 보시면 addTarget하는 함수가 이미 들어가 있습니다!
즉, resetLeftButtonAction는 파라미터로 받은 클로저를 자신의 프로퍼티인 leftButtonClosure에 담고 새로 addTarget을 실행해서 새로 담긴 leftButtonClosure (우리가 파라미터로 넣은 클로저)를 버튼 터치 액션으로 지정해주고 있습니다!
There was a problem hiding this comment.
와우 그랬군요... 코드를 더 살펴봤어야 햇네욥.. 감사합니다!
Comment on lines
+193
to
+195
| self.navibar.resetLeftButtonAction({ [weak self] in | ||
| self?.navigationController?.popViewController(animated: true) | ||
| }, .titleWithLeftButton) |
Comment on lines
8
to
27
| import UIKit | ||
|
|
||
| import Then | ||
|
|
||
| final class InfoView: UIView { | ||
|
|
||
| // MARK: - initialization | ||
|
|
||
| init() { | ||
| super.init(frame: .zero) | ||
| self.setUI() | ||
| self.setLayout() | ||
| self.setDelegate() | ||
| self.register() | ||
| } | ||
|
|
||
| required init?(coder: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") | ||
| } | ||
| } |
There was a problem hiding this comment.
실수입니다... 삭제할게요 ㅋ
Comment on lines
8
to
9
| import Foundation | ||
| import UIKit |
There was a problem hiding this comment.
import UIKit을 했으면 Foundation은 따로 import 해주지 않아도 됩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
생략
📮 관련 이슈