[Feat] #15 - GoalRewardInfoVC UI 구현 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsj8706
reviewed
Jan 2, 2023
|
|
||
| // MARK: - GoalRewardInfoCVC | ||
|
|
||
| class GoalRewardInfoCVC: UICollectionViewCell { |
|
|
||
| // MARK: - Identifier | ||
|
|
||
| static let identifier = "GoalRewardInfoCVC" |
There was a problem hiding this comment.
이거 이번에 추가한 utils중에 className을 사용하면 필요없어요!
Comment on lines
44
to
66
| // MARK: - Variables | ||
|
|
||
| var stampList: [GoalRewardInfoModel] = [ | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampC1, stampStandard: "그리기 스타터"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampC2, stampStandard: "그리기 중수"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampC3, stampStandard: "그리기 마스터"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampS1, stampStandard: "스크랩 베이비"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampS2, stampStandard: "스크랩 어린이"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampS3, stampStandard: "스크랩 어른이"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampP1, stampStandard: "새싹 업로더"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampP2, stampStandard: "중수 업로더"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampP3, stampStandard: "인플루언서"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampR1, stampStandard: "달리기 유망주"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampR2, stampStandard: "아마추어 선수"), | ||
| GoalRewardInfoModel(stampImg: ImageLiterals.imgStampR2, stampStandard: "마라톤 선수") | ||
| ] | ||
|
|
||
| // MARK: - Constants | ||
|
|
||
| final let stampInset: UIEdgeInsets = UIEdgeInsets(top: 32, left: 34, bottom: 10, right: 34) | ||
| final let stampLineSpacing: CGFloat = 20 | ||
| final let stampItemSpacing: CGFloat = 26 | ||
| final let stampCellHeight: CGFloat = 112 |
There was a problem hiding this comment.
이부분은 위에 UI Components 보다 위쪽에 위치하도록 하면 좋아요~!
| } | ||
|
|
||
| // MARK: - Methods |
Comment on lines
128
to
139
| stampBottomView.snp.makeConstraints { make in | ||
| make.top.equalTo(stampTopView.snp.bottom) | ||
| make.leading.trailing.equalTo(view.safeAreaLayoutGuide) | ||
| make.height.equalTo(view.safeAreaLayoutGuide).inset(80) | ||
| } | ||
|
|
||
| stampBottomView.addSubview(stampCollectionView) | ||
|
|
||
| stampCollectionView.snp.makeConstraints { make in | ||
| make.top.leading.trailing.equalToSuperview() | ||
| make.height.equalTo(calculateCellHeight()) | ||
| } |
There was a problem hiding this comment.
지금 보면 콜렉션 뷰를 stampBottomView로 감싸주고 있는데 그럴 필요 없어요!
모든 뷰를 감쌀 필요는 없습니다~!
저였으면 바로
stampCollectionView.snp.makContraints { make in
make.top.equalTo(stampTopView.snp.bottom)
make.leading.trailing.equalTo(view. safeAreaLayoutGuide)
make.bottom.equalToSuperView()
}콜렉션뷰에 레이아웃을 잡았을 거 같아요!! 그리고 콜렉션 뷰에서 calculateCellHeight()로 높이를 직접 구해서 넣어줄 필요 없어요!
오토 레이아웃만 제가 제시한 코드대로 잘 잡아주면 알아서 높이가 잘 잡힐거에요~!
| extension GoalRewardInfoVC: UICollectionViewDelegateFlowLayout { | ||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize { | ||
| let screenWidth = UIScreen.main.bounds.width | ||
| let tripleCellWidth = screenWidth - stampInset.left - stampInset.right - stampItemSpacing * 2 |
lsj8706
reviewed
Jan 2, 2023
|
|
||
| private func register() { | ||
| stampCollectionView.register(GoalRewardInfoCVC.self, | ||
| forCellWithReuseIdentifier: GoalRewardInfoCVC.identifier) |
There was a problem hiding this comment.
Suggested change
| forCellWithReuseIdentifier: GoalRewardInfoCVC.identifier) | |
| forCellWithReuseIdentifier: GoalRewardInfoCVC.className) |
으로 사용하면 identifier를 만들어줄 필요가 없어요
lsj8706
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
(몬말인지 아시겠나요??) 어떻게 할까욥
📸 스크린샷
📮 관련 이슈