Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
513sojin
commented
Nov 16, 2023
Comment on lines
-29
to
-33
| var completeButtonTapped: Driver<Void> { | ||
| completeButton.publisher(for: .touchUpInside) | ||
| .map { _ in } | ||
| .asDriver() | ||
| } |
There was a problem hiding this comment.
버튼에 publisher를 연결하는 과정을 combineCocoa를 사용하는 것으로 수정했습니다
Comment on lines
+247
to
+251
| self.completeButton.tapPublisher.sink { [weak self] _ in | ||
| guard let self = self else { return } | ||
| guard let text = self.bottomSheetTextField.text else { return } | ||
| self.completeButtonTapAction?(text) | ||
| }.store(in: cancelBag) |
There was a problem hiding this comment.
완성하기 버튼이 눌린 경우는 textfield의 내용을 클로저에 전달해주었습니다
| @@ -18,6 +18,7 @@ struct CourseDrawingRequestDto: Codable { | |||
|
|
|||
| struct CourseDrawingRequestData: Codable { | |||
| let path: [RNLocationModel] | |||
| // let title: String | |||
There was a problem hiding this comment.
서버 배포되면 title 관련 주석 삭제하도록 하겠습니당
thingineeer
approved these changes
Nov 16, 2023
| SelectedInfo.shared.type = .other | ||
| courseDrawingVC.setData(model: departureLocationModel) |
| @@ -25,14 +26,11 @@ final class CustomBottomSheetVC: UIViewController { | |||
| private var BottomsheetType: SheetType! | |||
|
|
|||
| var backgroundTapAction: (() -> Void)? | |||
| var completeButtonTapAction: ((String) -> Void)? | |||
| @@ -18,6 +18,7 @@ struct CourseDrawingRequestDto: Codable { | |||
|
|
|||
| struct CourseDrawingRequestData: Codable { | |||
| let path: [RNLocationModel] | |||
| // let title: String | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📮 관련 이슈