[Feat] #212 - 러닝 기록 상세페이지 메뉴 변경 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
러닝 기록 상세페이지 메뉴를 드롭다운으로 수정 하였습니다.
thingineeer
added
Chore
thingineeer
commented
Dec 3, 2023
| if textField == self.courseTitleTextField { | ||
| self.finishEditButtonDidTap() | ||
| if finishEditButton.isEnabled == true { |
There was a problem hiding this comment.
finishEditButton.isEnabled == true
이 코드는 수정을 한 상태를 표현하였기 때문에, 텍스트가 수정되었을 때만 return 키보드를 눌러야 작동이 되게 짰습니다.
513sojin
approved these changes
Dec 4, 2023
| } | ||
|
|
||
| let cancelAction = UIAlertAction(title: "닫기", style: .cancel, handler: nil) | ||
| dropDownTouchAction(menu: menu) |
There was a problem hiding this comment.
더 나은 코드를 향해 항상 수정하는 모습 너무 보기 좋아요 👍🏻
thingineeer
commented
Dec 4, 2023
Comment on lines
+46
to
+55
| private lazy var courseTitleTextField = UITextField().then { | ||
|
|
||
| $0.attributedPlaceholder = NSAttributedString( | ||
| string: "글 제목", | ||
| attributes: [.font: UIFont.h4, .foregroundColor: UIColor.g3] | ||
| ) | ||
| $0.font = .h4 | ||
| $0.textColor = .g1 | ||
| $0.addLeftPadding(width: 2) | ||
| $0.addTarget(self, action: #selector(textFieldTextDidChange), for: .editingChanged) |
There was a problem hiding this comment.
소진
새로운거 개발하는 와중에도 리팩토링 하는 모습 .. 진짜 본받겠습니다 😉
텍스트 필드의 텍스트(TextField.text)를 눌러야 .editingChanged 가 되는데.. 왜 텍스트 필드를 누르면 안 될까요..?
-> 근데 이건 무슨 상황인지 잘 파악이 안되는데 다시 설명해주실 수 있나요 ㅜㅜ
마이페이지 -> 러닝 기록 보시면 수정하기 누르고 제목을 수정하는 과정에서,
텍스트 필드를 누르면 안 되고.. 텍스트 필드의 텍스트를 눌러야만 수정하기가 되더라고요..?
merge 전에도 똑같아서 생각나실때 보셔도 좋을 것 같아요!
There was a problem hiding this comment.
흠 가서 해봤는데 왜 text 부분 눌러야지만 수정되는지 모르겠네요 ,, 딱히 의도가 있을거 같지는 않은데 ㅠ
There was a problem hiding this comment.
흑흑.. 배포 전에 꼭 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
TextField.text)를 눌러야.editingChanged가 되는데.. 왜 텍스트 필드를 누르면 안 될까요..? ,, 기존 코드의 어떤 문제점이 있을지 ... !?📸 스크린샷
📮 관련 이슈